[close #433] fix calling getStoreById without backoffer #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
marsishandsome
force-pushed
the
feature/fix-seekLeaderStore-backoff-master
branch
from
67e5ff1
to
b757b2b
Compare
|
/run-all-tests |
zz-jason
reviewed
Dec 24, 2021
| @@ -185,6 +184,7 @@ public boolean canRetryAfterSleep(BackOffFunction.BackOffFuncType funcType, long | |||
| } | |||
| } | |||
|
|
|||
| SlowLogSpan slowLogSpan = getSlowLog().start("backoff " + funcType.name()); | |||
There was a problem hiding this comment.
why move it here? should BACKOFF_DURATION also be moved?
There was a problem hiding this comment.
there is a return in line 184, which will cause "end":"N/A",.
it's hard to understand it.
There was a problem hiding this comment.
got. then why not move BACKOFF_DURATION to here as well?
There was a problem hiding this comment.
Moving these lines to here might cause we can't see the backoff in slow log.
There was a problem hiding this comment.
We may end this span while returning though we will see this backoff end shortly but this span is still there.
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/fix-seekLeaderStore-backoff-master
branch
from
b757b2b
to
ab8cf80
Compare
|
/run-all-tests |
marsishandsome
force-pushed
the
feature/fix-seekLeaderStore-backoff-master
branch
from
ab8cf80
to
5afd1b9
Compare
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/fix-seekLeaderStore-backoff-master
branch
from
5afd1b9
to
1933ca1
Compare
|
/run-all-tests |
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
ti-srebot
approved these changes
Dec 24, 2021
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 24, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #440 |
|
Rest LGTM |
marsishandsome
added a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 24, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
added a commit
that referenced
this pull request
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #433
Timeout in seekLeaderStore is not limited.
We should use
backofferfor all the gRPC calls.