Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[close #419] upgrade kvproto to fix rawBatchPut compatibility #441

Merged
merged 5 commits into from
Dec 31, 2021
Merged

[close #419] upgrade kvproto to fix rawBatchPut compatibility #441

merged 5 commits into from
Dec 31, 2021

Conversation

iosmanthus
Copy link
Member

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #419

Problem Description: rawBatchPut can access TiKV (version < v5.3.0)

What is changed and how it works?

Upgrading kvproto to fix the forward compatibility of RawBatchPutRequest.

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Integration test
  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

@iosmanthus
upgrade kvproto to fix batch put
1ac488e 
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@iosmanthus iosmanthus changed the title [#419] upgrade kvproto to fix rawBatchPut compatibility [close #419] [WIP] upgrade kvproto to fix rawBatchPut compatibility Dec 24, 2021
@iosmanthus
Copy link
Member Author

DNM until pingcap/kvproto#844 merged.

@iosmanthus
use pingcap kvproto
0030aa8 
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@iosmanthus iosmanthus changed the title [close #419] [WIP] upgrade kvproto to fix rawBatchPut compatibility [close #419] upgrade kvproto to fix rawBatchPut compatibility Dec 24, 2021
@iosmanthus
Copy link
Member Author

This pull request can review now @zz-jason @marsishandsome @birdstorm

zz-jason
zz-jason reviewed Dec 24, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some tests?

@iosmanthus
Copy link
Member Author

could you add some tests?

We may create another pull request to cover this issue because the tests might expose other issues of compatibility.

@iosmanthus iosmanthus mentioned this pull request Dec 24, 2021
Merged
2 tasks
@birdstorm
Copy link
Collaborator

i think there are compatibility problems relating to kvproto version change. Is there any description about the affected versions?

@iosmanthus
Copy link
Member Author

i think there are compatibility problems relating to kvproto version change. Is there any description about the affected versions?

It is described in #419, the master branch of client-java can not access TiKV with a version lower than 5.3.0.

marsishandsome
marsishandsome approved these changes Dec 27, 2021
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason reviewed Dec 27, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iosmanthus could you add some test?

@iosmanthus
Copy link
Member Author

/run-all-tests tikv = release-5.0

@iosmanthus
Copy link
Member Author

@zz-jason PTAL

zz-jason
zz-jason approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@iosmanthus merge failed.

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@iosmanthus merge failed.

@iosmanthus
Copy link
Member Author

/run-all-tests

@iosmanthus
Copy link
Member Author

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@iosmanthus merge failed.

@iosmanthus
Copy link
Member Author

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@marsishandsome marsishandsome merged commit 5dbfe03 into tikv:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@marsishandsome marsishandsome marsishandsome approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@birdstorm birdstorm Awaiting requested review from birdstorm

Assignees
No one assigned
Labels
status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RawKVClient#batchPut is broken
5 participants
@iosmanthus @birdstorm @zz-jason @ti-srebot @marsishandsome