Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[to #436] fix license header for files other than org.tikv.common #448

Merged
merged 3 commits into from
Dec 28, 2021

Conversation

zz-jason
Copy link
Member

Signed-off-by: Jian Zhang zjsariel@gmail.com

What problem does this PR solve?

Issue Number: to #436

Problem Description: the license header is incorrect for these packages.

What is changed and how it works?

all the changes are made by license-eye:

./license-eye -c .github/license-checker.yml header fix

license-eye can be compiled via the following commands:

git clone https://github.com/apache/skywalking-eyes
cd skywalking-eyes
make build

then you can find the compiled src/license-eye

Code changes

  • No code

Check List for Tests

This PR has been tested by the at least one of the following methods:

  • No code

Side effects

  • NO side effects

Related changes

  • NO related changes

Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
@zz-jason zz-jason changed the title [to #436] fix license header for raw, service, txn packages [to #436] fix license header for source files other than org.tikv.common Dec 27, 2021
@zz-jason zz-jason changed the title [to #436] fix license header for source files other than org.tikv.common [to #436] fix license header for files other than org.tikv.common Dec 27, 2021
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 85aa641 into tikv:master Dec 28, 2021
@zz-jason zz-jason deleted the refine/license-1 branch December 28, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants