[to #348] Add examples to docs #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
zz-jason
reviewed
Dec 29, 2021
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
docs/src/examples/txnkv.md
Outdated
Comment on lines
49
to
53
| TiRegion region = session.getRegionManager().getRegionByKey(key1); | ||
| try (RegionStoreClient client = session.getRegionStoreClientBuilder().build(region)) { | ||
| client.prewrite(backOffer, key1, mutations, 10, startTS, false); | ||
| client.commit(backOffer, commitKeys, startTS, commitTS); | ||
| } |
There was a problem hiding this comment.
That's not how to write data to TxnKV.
Please refer to TwoPhaseCommitter
There was a problem hiding this comment.
The TwoPhaseCommitter API for writing data to TxnKV is too low level.
We should provide a high level API.
zz-jason
reviewed
Jan 4, 2022
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
zz-jason
reviewed
Jan 7, 2022
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com> Co-authored-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
|
A demo could be found at http://172.16.5.32:3001/ |
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
zz-jason
reviewed
Feb 7, 2022
zz-jason
reviewed
Feb 7, 2022
Signed-off-by: Peng Guanwen <pg999w@outlook.com> Co-authored-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
andylokandy
reviewed
Feb 10, 2022
andylokandy
reviewed
Feb 10, 2022
| @@ -0,0 +1,69 @@ | |||
| # TxnKV | |||
There was a problem hiding this comment.
@zz-jason This is a little bit too low-level... Should we give example for txnkv?
There was a problem hiding this comment.
It's OK, we can update this document once there are easy ways to interact with transactions.
|
rest LGTM |
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
andylokandy
approved these changes
Feb 11, 2022
ti-srebot
approved these changes
Feb 11, 2022
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peng Guanwen pg999w@outlook.com
What problem does this PR solve?
Issue Number: part of #348
Problem Description: Add examples to the documentation.
What is changed and how it works?
Code changes
Check List for Tests
This PR has been tested by the at least one of the following methods:
Side effects
Related changes