[to #462] add version constraint for rawkv tests #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
| @@ -21,6 +21,21 @@ | |||
| import org.tikv.util.TestUtils; | |||
|
|
|||
| public class BaseRawKVTest { | |||
|
|
|||
| protected String getTiKVVersion() { | |||
| String tikvVersion = TestUtils.getEnv("TIKV_VERSION"); | |||
There was a problem hiding this comment.
Who will set the TIKV_VERSION?
There was a problem hiding this comment.
we can get the tikv version from TiKV, see https://github.com/tikv/client-java/blob/master/src/main/java/org/tikv/common/StoreVersion.java.
There was a problem hiding this comment.
Who will set the
TIKV_VERSION?
By design, like RAWKV_PD_ADDRESSES, it will be set by the test executor.
9 tasks
…-constraint-for-tests
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
ti-srebot
approved these changes
Jan 4, 2022
|
/merge |
|
/run-all-tests |
iosmanthus
changed the title
iosmanthus
changed the title
iosmanthus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #462
Problem Description:
Some tests in the master branch are not compatible with older versions of TiKV, we need to add some version constraints to these tests and furthermore, add integration compatibility tests for the master branch.
What is changed and how it works?
Use
Assumeto ignore some tests with version info reading from ENV.Check List for Tests
This PR has been tested by at least one of the following methods: