Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #465] implement AutoClosable for TwoPhaseCommitter #466

Merged
merged 6 commits into from
Jan 5, 2022

Conversation

peng1999
Copy link
Member

@peng1999 peng1999 commented Jan 4, 2022

What problem does this PR solve?

Issue Number: close #465

Problem Description: implement AutoClosable for TwoPhaseCommitter

What is changed and how it works?

Code changes

Check List for Tests

This PR has been tested by the at least one of the following methods:

  • Manual test (add detailed scripts or steps below)

Side effects

  • NO side effects

Related changes

  • NO related changes

close tikv#465

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

peng1999 commented Jan 4, 2022

/cc @marsishandsome @zz-jason

Copy link
Member

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some tests about the behavior of AutoCloseable?

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@zz-jason
Copy link
Member

zz-jason commented Jan 5, 2022

@peng1999 please fix the failure reported by license checker

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Jan 5, 2022

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@iosmanthus
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@zz-jason zz-jason merged commit a0ef75d into tikv:master Jan 5, 2022
@peng1999 peng1999 deleted the auto-close branch January 5, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TwoPhaseCommitter should implement AutoClosable
4 participants