-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #480] add metrics inside grpc and netty #484
Merged
marsishandsome
merged 1 commit into
tikv:master
from
marsishandsome:feature/add-metrics-inside-grpc-netty
Jan 20, 2022
Merged
[close #480] add metrics inside grpc and netty #484
marsishandsome
merged 1 commit into
tikv:master
from
marsishandsome:feature/add-metrics-inside-grpc-netty
Jan 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsishandsome
changed the title
[close #480] add metrics inside grpc and netty
[WIP] [close #480] add metrics inside grpc and netty
Jan 18, 2022
marsishandsome
added
needs-cherry-pick-3.1
and removed
component/common
component/rawkv
labels
Jan 18, 2022
marsishandsome
force-pushed
the
feature/add-metrics-inside-grpc-netty
branch
from
January 18, 2022 07:02
db1c0b3
to
e518482
Compare
marsishandsome
force-pushed
the
feature/add-metrics-inside-grpc-netty
branch
4 times, most recently
from
January 18, 2022 08:13
820d862
to
dea2a87
Compare
marsishandsome
changed the title
[WIP] [close #480] add metrics inside grpc and netty
[close #480] add metrics inside grpc and netty
Jan 18, 2022
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/add-metrics-inside-grpc-netty
branch
from
January 18, 2022 08:20
dea2a87
to
89ade30
Compare
/run-all-tests |
marsishandsome
requested review from
birdstorm,
iosmanthus,
sunxiaoguang and
zz-jason
January 18, 2022 08:21
LGTM |
birdstorm
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
approved these changes
Jan 20, 2022
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jan 20, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.1 in PR #488 |
marsishandsome
added a commit
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
What problem does this PR solve?
Issue Number: close #480
What is changed and how it works?
add metrics inside grpc and netty