[to #477] Change SlowLog interface to align with tracing #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
ref tikv#477 Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
|
I think we also need to fill the |
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
andylokandy
reviewed
Jan 25, 2022
| return Kvrpcpb.Context.newBuilder(context) | ||
| .setTraceContext( | ||
| Tracepb.TraceContext.newBuilder() | ||
| .setDurationThresholdMs((int) slowLog.getThresholdMS()) |
There was a problem hiding this comment.
I think we should set the threshold for tikv less than the client. Maybe half of the client threshold? @marsishandsome what do you think?
There was a problem hiding this comment.
Should we make the factor(client threshold / tikv threshold) configurable?
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
zz-jason
reviewed
Feb 9, 2022
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
zz-jason
reviewed
Feb 9, 2022
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
ti-srebot
approved these changes
Feb 10, 2022
|
/merge |
|
/run-all-tests |
|
@peng1999 merge failed. |
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
zz-jason
approved these changes
Feb 10, 2022
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peng Guanwen pg999w@outlook.com
What problem does this PR solve?
Issue Number: to #477
Problem Description: See Proposal
What is changed and how it works?
SlowLogandSlowLogSpanare adjusted.SlowLogImplandSlowLogSpanImplare refined.Code changes
Check List for Tests
This PR has been tested by the at least one of the following methods:
Related changes