Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[to #480] add netty allocator source code #486

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

iosmanthus
Copy link
Member

@iosmanthus iosmanthus commented Jan 20, 2022

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: to #480

Add source code overlay for io.netty.buffer, prepare the base for the task of adding metrics for allocation time and rate.

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marsishandsome and others added 3 commits January 20, 2022 13:39
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iosmanthus
Copy link
Member Author

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@iosmanthus merge failed.

@marsishandsome
Copy link
Collaborator

/run-all-tests

@marsishandsome
Copy link
Collaborator

/build

@marsishandsome
Copy link
Collaborator

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jan 21, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #492

marsishandsome pushed a commit that referenced this pull request Jan 21, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: iosmanthus <dengliming@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants