Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #511] add LockSupport metrics #512

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

haojinming
Copy link
Contributor

@haojinming haojinming commented Feb 10, 2022

Signed-off-by: haojinming jinming.hao@pingcap.com

What problem does this PR solve?

Add metrics for ThreadlessExcutor LockSupport.park/unpark, them may take sone time when many threads are running.

Issue Number: close #511

Check List for Tests

This PR has been tested by the at least one of the following methods:

  • Manual test (add detailed scripts or steps below)

@zz-jason zz-jason changed the title [close #511 ]add LockSupport metrics [close #511] add LockSupport metrics Feb 10, 2022
@zz-jason
Copy link
Member

please fix DCO

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: haojinming <jinming.hao@pingcap.com>
@haojinming
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@zz-jason zz-jason merged commit 84bff75 into tikv:master Feb 11, 2022
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 failed

@haojinming haojinming deleted the add_metric_for_lock branch June 29, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics for grpc ThreadlessExecutor lock
4 participants