Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #515] Slowlog: Always calculate duration #516

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

peng1999
Copy link
Member

Signed-off-by: Peng Guanwen pg999w@outlook.com

What problem does this PR solve?

Issue Number: close #515

Problem Description: Always calculate duration in slowlog

What is changed and how it works?

Code changes

Check List for Tests

This PR has been tested by the at least one of the following methods:

  • Unit test

Side effects

  • NO side effects

Related changes

  • NO related changes

fix tikv#515

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/cc @zz-jason @andylokandy

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@andylokandy
Copy link
Contributor

/merge

@andylokandy andylokandy reopened this Feb 15, 2022
@andylokandy
Copy link
Contributor

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@zz-jason zz-jason merged commit a0e35b5 into tikv:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slowlog does not record total duration time when error happend
5 participants