Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #520] add communication method in README #521

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

zz-jason
Copy link
Member

Signed-off-by: Jian Zhang zjsariel@gmail.com

What problem does this PR solve?

Issue Number: close #520

Problem Description: as the issues said, no direction for users and contributors to ask help

What is changed and how does it work?

add slack and asktug links to the communication section.

Code changes

  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • No code

Side effects

  • NO side effects

Related changes

  • NO related changes

Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
2. [Spotbugs Reports](https://tikv.github.io/client-java/site/spotbugs.html)
3. [Source Code Xref](https://tikv.github.io/client-java/site/xref/index.html)

## Community

Communication:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may change this section title to Forum, since we may have other community entities.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment addressed, PTAL.

@iosmanthus
Copy link
Member

Rest LGTM

Signed-off-by: Jian Zhang <zjsariel@gmail.com>
@zz-jason
Copy link
Member Author

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@zz-jason zz-jason merged commit ef1abb3 into tikv:master Feb 16, 2022
@zz-jason zz-jason deleted the docs/add-communication-section branch February 16, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add communication section in README to help users and contributors able to find help
4 participants