Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #528] add workflows to check staleness and PR title #529

Merged
merged 4 commits into from
Feb 21, 2022

Conversation

zz-jason
Copy link
Member

What problem does this PR solve?

Issue Number: [close #528]

Problem Description: as the issue said:

some routine work needs to be automated:

  • check whether the issue or pr is stale and close it if necessary
  • check whether the pr title is as expected and notify the author to modify it if not

What is changed and how it works?

add github actions

Code changes

  • No code

Check List for Tests

This PR has been tested by the at least one of the following methods:

  • No code

Side effects

  • NO side effects

Related changes

  • NO related changes

Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

days-before-stale: 30
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this will be closed in 5 days.'
stale-issue-label: 'status/stale'
days-before-issue-close: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be 5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently we don't need to close stale issues since almost all these issues need to be solved.

days-before-stale: 30
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this will be closed in 5 days.'
stale-issue-label: 'status/stale'
days-before-issue-close: -1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently we don't need to close stale issues since almost all these issues need to be solved.

- uses: actions/stale@v4
with:
days-before-stale: 30
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this will be closed in 5 days.'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this will be closed in 5 days.'
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity.'

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #529 (fb16269) into master (49476d7) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #529      +/-   ##
============================================
+ Coverage     30.88%   30.94%   +0.06%     
- Complexity     1270     1274       +4     
============================================
  Files           278      278              
  Lines         17343    17343              
  Branches       1975     1975              
============================================
+ Hits           5356     5367      +11     
+ Misses        11393    11381      -12     
- Partials        594      595       +1     
Impacted Files Coverage Δ
src/main/java/io/grpc/netty/NettyClientStream.java 74.07% <0.00%> (-1.49%) ⬇️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 54.52% <0.00%> (-1.30%) ⬇️
...java/org/tikv/common/region/RegionStoreClient.java 47.85% <0.00%> (-0.31%) ⬇️
...ty/handler/codec/http2/Http2ConnectionHandler.java 50.36% <0.00%> (ø)
src/main/java/io/grpc/internal/ClientCallImpl.java 56.82% <0.00%> (+0.48%) ⬆️
src/main/java/io/grpc/netty/WriteQueue.java 75.18% <0.00%> (+2.25%) ⬆️
src/main/java/io/grpc/stub/ClientCalls.java 48.51% <0.00%> (+2.31%) ⬆️
...va/org/tikv/common/region/StoreHealthyChecker.java 63.15% <0.00%> (+11.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49476d7...fb16269. Read the comment docs.

@andylokandy
Copy link
Contributor

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@zz-jason zz-jason merged commit 2ac49bb into tikv:master Feb 21, 2022
@zz-jason zz-jason deleted the workflow/add-2-checker branch February 21, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utilize github action to automate the routine work
4 participants