-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix #537] fix convert byte[] to long error #538
Conversation
@shiyuhang0 thanks for your contribution! please:
|
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
============================================
+ Coverage 33.23% 34.06% +0.83%
- Complexity 1338 1361 +23
============================================
Files 270 270
Lines 17131 17131
Branches 1950 1950
============================================
+ Hits 5693 5836 +143
+ Misses 10833 10681 -152
- Partials 605 614 +9
Continue to review full report at Codecov.
|
194d8aa
to
ddd4dbd
Compare
have done, PTAL |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shiyuhang0 please fix license check and code format check failures. |
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
5c72c8d
to
022ac19
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rest LGTM. However, @marsishandsome is working on removing the coprocessor code out of the code base. This pull request might suffer from this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Issue Number: fix #537
Problem Description: convert byte[] to long error in TiChunkColumnVector#getLongFromBinary
What is changed and how it works?
When long and byte do
|
operation, I guess byte is converted to long, It make the wrong answer.So, Use 0xff to intercept the last eight binary data
Check List for Tests
This PR has been tested by the at least one of the following methods:
Side effects
Related changes