Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #540] rawkv: fix scan return empty set while exist empty key (#541) #548

Merged

Conversation

iosmanthus
Copy link
Member

cherry-pick #541 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/548

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #540

Problem Description:

This pull request adds an empty key check for RawScanIterator.hasNext, otherwise, if there is an empty key in TiKV, the scan will always return an empty set.

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Integration test

iosmanthus and others added 2 commits March 1, 2022 15:05
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-3.1@fdb67bc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.1     #548   +/-   ##
==============================================
  Coverage               ?   29.12%           
  Complexity             ?     1139           
==============================================
  Files                  ?      263           
  Lines                  ?    16526           
  Branches               ?     1892           
==============================================
  Hits                   ?     4814           
  Misses                 ?    11186           
  Partials               ?      526           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb67bc...58939db. Read the comment docs.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit e72ba8b into tikv:release-3.1 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants