Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #552] delete Netty Allocator on grafana #553

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

marsishandsome
Copy link
Collaborator

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

Issue Number: close #552

Problem Description: Display problem with Netty Allocator on grafana

What is changed and how it works?

Delete Netty Allocator on grafana

Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #553 (7246a6a) into master (36d0109) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #553      +/-   ##
============================================
- Coverage     32.98%   32.87%   -0.12%     
+ Complexity     1332     1326       -6     
============================================
  Files           270      270              
  Lines         17054    17054              
  Branches       1950     1950              
============================================
- Hits           5625     5606      -19     
- Misses        10821    10848      +27     
+ Partials        608      600       -8     
Impacted Files Coverage Δ
...ty/handler/codec/http2/Http2ConnectionHandler.java 48.65% <0.00%> (-2.94%) ⬇️
src/main/java/io/grpc/netty/WriteQueue.java 74.43% <0.00%> (-2.26%) ⬇️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 56.03% <0.00%> (-0.87%) ⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java 56.82% <0.00%> (-0.25%) ⬇️
...va/org/tikv/common/region/StoreHealthyChecker.java 73.68% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d0109...7246a6a. Read the comment docs.

@marsishandsome marsishandsome changed the title [# close 552] delete Netty Allocator on grafana [#close 552] delete Netty Allocator on grafana Mar 3, 2022
@marsishandsome marsishandsome changed the title [#close 552] delete Netty Allocator on grafana [close #552] delete Netty Allocator on grafana Mar 3, 2022
@marsishandsome
Copy link
Collaborator Author

@iosmanthus @zz-jason PTAL

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iosmanthus
Copy link
Member

Seems it is caused by the wrong datasource?

@marsishandsome marsishandsome enabled auto-merge (squash) March 24, 2022 06:48
@marsishandsome marsishandsome merged commit 7278d5a into tikv:master Mar 24, 2022
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Mar 24, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #568

ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Mar 24, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.2 in PR #569

marsishandsome added a commit that referenced this pull request Mar 24, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
marsishandsome added a commit that referenced this pull request Mar 24, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display problem with Netty Allocator on grafana
4 participants