Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #616] check store version while using API V2 (#617) #620

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 20, 2022

cherry-pick #617 to release-3.3
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/620

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/620:release-3.3-d6a15c4cccf5

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #616

What is changed and how does it work?

Check version bound in TiSession ctor.

Code changes

  • Has exported variable/fields change

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick the release branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-3.3@191cea0). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-3.3     #620   +/-   ##
==============================================
  Coverage               ?   34.44%           
  Complexity             ?     1410           
==============================================
  Files                  ?      278           
  Lines                  ?    17354           
  Branches               ?     1972           
==============================================
  Hits                   ?     5978           
  Misses                 ?    10764           
  Partials               ?      612           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191cea0...93124e3. Read the comment docs.

@iosmanthus iosmanthus merged commit 1267187 into tikv:release-3.3 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants