Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #679] Let ColumnRef case insensitive (#678) #690

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Dec 20, 2022

cherry-pick #678 to release-3.3
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/690

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/690:release-3.3-1554ae5feccf

Signed-off-by: shiyuhang 1136742008@qq.com

What problem does this PR solve?

Problem Description: close #679

ColumnRef should be case insensitive

What is changed and how does it work?

Change the hashcode method

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-3.3@6efa139). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-3.3     #690   +/-   ##
==============================================
  Coverage               ?   34.91%           
  Complexity             ?     1438           
==============================================
  Files                  ?      278           
  Lines                  ?    17382           
  Branches               ?     1975           
==============================================
  Hits                   ?     6069           
  Misses                 ?    10702           
  Partials               ?      611           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhangyangyu zhangyangyu merged commit 571a47c into tikv:release-3.3 Dec 20, 2022
shiyuhang0 pushed a commit to shiyuhang0/client-java that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants