Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #716] Fix pair (#724) #727

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #724

What problem does this PR solve?

Issue Number: close #716

Problem Description: TBD

What is changed and how does it work?

override equals and hashcode

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

Signed-off-by: shiyuhang <1136742008@qq.com>
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-3.3@c85eeae). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-3.3     #727   +/-   ##
==============================================
  Coverage               ?   37.88%           
  Complexity             ?     1606           
==============================================
  Files                  ?      278           
  Lines                  ?    17469           
  Branches               ?     1986           
==============================================
  Hits                   ?     6619           
  Misses                 ?    10190           
  Partials               ?      660           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shiyuhang0 shiyuhang0 merged commit d8f7a54 into tikv:release-3.3 Mar 7, 2023
@ti-srebot
Copy link
Collaborator

@shiyuhang0, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants