Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Committing a delete must unlock #234

Closed
nrc opened this issue Feb 16, 2021 · 0 comments · Fixed by #253
Closed

Committing a delete must unlock #234

nrc opened this issue Feb 16, 2021 · 0 comments · Fixed by #253
Labels
bug Something isn't working
Milestone
0.1.0 release

Comments

@nrc
Copy link
Collaborator

nrc commented Feb 16, 2021

When we delete in a pessimistic transaction, we first lock the key. However, if our transaction first inserts a value, then deletes it, we do this all in the buffer and our prewrite only sends a 'check not exists' message to TiKV. That leaves the key locked, we should unlock it.
@nrc nrc added the bug Something isn't working label Feb 16, 2021
@nrc nrc added this to the 0.1.0 release milestone Mar 5, 2021
nrc added a commit to nrc/client-rust that referenced this issue Apr 9, 2021
@nrc
Fix two bugs with insert and delete
8b5fc19 
Fixes tikv#234

Signed-off-by: Nick Cameron <nrc@ncameron.org>
@nrc nrc mentioned this issue Apr 9, 2021
Merged
nrc added a commit to nrc/client-rust that referenced this issue Apr 9, 2021
@nrc
Fix two bugs with insert and delete
e4097d4 
Fixes tikv#234

Signed-off-by: Nick Cameron <nrc@ncameron.org>
nrc added a commit to nrc/client-rust that referenced this issue Apr 9, 2021
@nrc
Fix two bugs with insert and delete
c2987a8 
Fixes tikv#234

Signed-off-by: Nick Cameron <nrc@ncameron.org>
nrc added a commit to nrc/client-rust that referenced this issue Apr 13, 2021
@nrc
Fix two bugs with insert and delete
d782bfe 
Fixes tikv#234

Signed-off-by: Nick Cameron <nrc@ncameron.org>
nrc added a commit to nrc/client-rust that referenced this issue Apr 13, 2021
@nrc
Fix two bugs with insert and delete
96c1b2a 
Fixes tikv#234

Signed-off-by: Nick Cameron <nrc@ncameron.org>
nrc added a commit to nrc/client-rust that referenced this issue Apr 13, 2021
@nrc
Fix two bugs with insert and delete
7493015 
Fixes tikv#234

Signed-off-by: Nick Cameron <nrc@ncameron.org>
nrc added a commit to nrc/client-rust that referenced this issue Apr 13, 2021
@nrc
Fix two bugs with insert and delete
13fabea 
Fixes tikv#234

Signed-off-by: Nick Cameron <nrc@ncameron.org>
nrc added a commit to nrc/client-rust that referenced this issue Apr 13, 2021
@nrc
Fix two bugs with insert and delete
e8a9175 
Fixes tikv#234

Signed-off-by: Nick Cameron <nrc@ncameron.org>
@nrc nrc closed this as completed in #253 Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.0 release
Development

Successfully merging a pull request may close this issue.

Fix two bugs with insert and delete nrc/client-rust
1 participant
@nrc