Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging #267

Open
nrc opened this issue Apr 20, 2021 · 1 comment
Open

Logging #267

nrc opened this issue Apr 20, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nrc
Copy link
Collaborator

nrc commented Apr 20, 2021

We do very minimal logging - a total of six locations log any data. Either we should do proper logging, or we should remove those six logging locations and the dependency.
@shashwatj07 shashwatj07 mentioned this issue May 25, 2021
Merged
@ekexium
Copy link
Collaborator

ekexium commented Jul 21, 2021 •
edited
Loading

Some of my thoughts on the slog migration:

  • Pass the logger around and modify all logging macros
  • Make use of the structured logger to propagate txn's info, e.g. start_ts.
  • Choose an appropriate slog format that makes debugging easier.
  • Remove the wrong child!()s
  • Logs for errors, e.g. "drop active txn"
  • Debug logs for trivial opeartions, which is useful in dev/debug
  • Update examples and docs

@ekexium ekexium added enhancement New feature or request good first issue Good for newcomers labels Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrc @ekexium