-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added logs #294
added logs #294
Conversation
7307685
to
2066ed4
Compare
Thanks! I think in most cases we don't want to see plenty of such logs. So they'd better be in debug level. And I think there still be other work to improve logging. So we don't close #267 for now. |
I've changed them accordingly.
Yes, I know. I'll add some more in this PR. Please suggest what all to add. Thanks for the help. |
e5b4823
to
7b441a9
Compare
Signed-off-by: Shashwat Jaiswal <shashwatjaiswal2001@gmail.com>
Maybe we need to use slog so that we can connect the logs between user invocation and internal requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
In terms of other logging, I think we can have more info!
for non-trivial events. Maybe some warn!
for unexpected but recoverable errors.
resolvesPart of #267