Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus should be optional and hide under feature gate #407

Closed
Xuanwo opened this issue Jul 13, 2023 · 5 comments · Fixed by #433
Closed

prometheus should be optional and hide under feature gate #407

Xuanwo opened this issue Jul 13, 2023 · 5 comments · Fixed by #433
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jul 13, 2023 •
edited
Loading

prometheus should be enabled by default when users don't need it. We would better hide prometheus under feature gate instead.
@Xuanwo Xuanwo added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jul 13, 2023
@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 20, 2023

Related to apache/opendal#3612, prometheus will also include reqwest with native-tls enable.

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 20, 2023

@pingyu, do you think it's a good idea to make prometheus optional?

@Xuanwo Xuanwo mentioned this issue Nov 20, 2023
Closed
@pingyu
Copy link
Collaborator

pingyu commented Nov 20, 2023

@pingyu, do you think it's a good idea to make prometheus optional?

Yes~

@Xuanwo Xuanwo mentioned this issue Nov 20, 2023
Merged
@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 21, 2023

Can you make a patch release for this change? Thanks!

@iosmanthus
Copy link
Member

Can you make a patch release for this change? Thanks!

@andylokandy PTAL

@andylokandy andylokandy mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
3 participants
@pingyu @Xuanwo @iosmanthus