Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Put test cases exercising fail points into their own test crate" — is 'crate' right? #52

Open
8573 opened this issue Apr 12, 2020 · 1 comment
Labels

Comments

@8573
Copy link

8573 commented Apr 12, 2020

The fail crate's crate-level doc-comment first says—

fail-rs/src/lib.rs

Lines 107 to 108 in 2cf1175

//! this it is a best practice to put all fail point unit tests into their own
//! binary. Here's an example of a snippet from `Cargo.toml` that creates a

—and then later says—

fail-rs/src/lib.rs

Lines 219 to 220 in 2cf1175

//! fail points. Put test cases exercising fail points into their own test
//! crate.

Should the latter advice say "binary" rather than "crate"?

@BusyJay
Copy link
Member

BusyJay commented Apr 22, 2020

I think you are correct. What do you think? /cc @brson?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants