benchmark: fix shutdown failure #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overvenus
reviewed
Dec 12, 2017
benchmark/src/client.rs
Outdated
| @@ -143,6 +143,17 @@ impl<B: Backoff> ExecutorContext<B> { | |||
| } | |||
| } | |||
|
|
|||
| // Since impl trait is not stable yet, implement this as a function is impossible without box. | |||
| macro_rules! spawn { | |||
There was a problem hiding this comment.
What's the difference between the fn spawn() above?
There was a problem hiding this comment.
client can be different types.
There was a problem hiding this comment.
Could we remove the above fn spawn() ?
|
PTAL @AndreMouche |
AndreMouche
reviewed
Dec 12, 2017
benchmark/src/bench.rs
Outdated
| @@ -26,16 +30,28 @@ fn gen_resp(req: SimpleRequest) -> SimpleResponse { | |||
| resp | |||
| } | |||
|
|
|||
|
|
|||
benchmark/src/client.rs
Outdated
| @@ -143,6 +143,17 @@ impl<B: Backoff> ExecutorContext<B> { | |||
| } | |||
| } | |||
|
|
|||
| // Since impl trait is not stable yet, implement this as a function is impossible without box. | |||
| macro_rules! spawn { | |||
There was a problem hiding this comment.
Could we remove the above fn spawn() ?
BusyJay
force-pushed
the
fix-benchmark
branch
from
3816671
to
6ec3281
Compare
overvenus
approved these changes
Dec 13, 2017
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes an hang-up-forever issue during benchmark.
To add all the stats 1.7.2 introduces, we need a public API and compatible rust-protobuf. See grpc/grpc#13705 and stepancheg/rust-protobuf#260.
/cc #107 #118
After this pr is merged, I think we are ready to release 0.2.0.