Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TiKV dependency to 3.0.0. #8

Merged
merged 4 commits into from Jul 11, 2019
Merged

Update TiKV dependency to 3.0.0. #8

merged 4 commits into from Jul 11, 2019

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Jul 5, 2019

What have you changed? (mandatory)

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

cargo check passes

Does this PR affect TiDB Lightning? (mandatory)

No

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

kennytm and others added 2 commits July 6, 2019 03:00
@kennytm
Cargo.toml: update tikv dependency to 3.0.0 GA
9575986 
Signed-off-by: kennytm <kennytm@gmail.com>
@Hoverbear @kennytm
PD Connection: Retry for infinity, log periodically (#4502)
89ffa31 
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@kennytm kennytm added the status/PTAL This PR is ready for review. Add this label back after committing new changes label Jul 5, 2019
@Connor1996 @kennytm
engine: check iter status when scanning (#4863) (#4936)
b671b80 
* engine: check iter status when scanning (#4863)

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@kennytm
Copy link
Collaborator Author

kennytm commented Jul 6, 2019

/test

2 similar comments
@zhouqiang-cl
Copy link

/test

@zhouqiang-cl
Copy link

/test

@kennytm
*: run rustfmt
9e7ef3e 
Signed-off-by: kennytm <kennytm@gmail.com>
@zhouqiang-cl
Copy link

/rebuild

@kennytm
Copy link
Collaborator Author

kennytm commented Jul 10, 2019

PTAL @leoppro @lance6716

lance6716
lance6716 reviewed Jul 10, 2019
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

though I'm still learning and don't fully understand logic in stream.rs, I did my best to check that logic keeps same with previous version plus a RocksDB Error.

@lance6716 lance6716 added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 10, 2019
@zier-one
Copy link
Member

LGTM

@zier-one zier-one added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Jul 10, 2019
@kennytm
Copy link
Collaborator Author

kennytm commented Jul 11, 2019

@leoppro @lance6716 could either one of you approve the PR? Needs ≥1 approval to merge. Thanks.

@zier-one
Copy link
Member

@leoppro @lance6716 could either one of you approve the PR? Needs ≥1 approval to merge. Thanks.

I am sorry, I forgot it

@kennytm kennytm merged commit 52bfb76 into master Jul 11, 2019
@kennytm kennytm deleted the kennytm/update-deps branch July 11, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 left review comments

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kennytm @zhouqiang-cl @zier-one @lance6716 @Hoverbear @Connor1996