Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix definition of c_bool for non-MSVC targets. #54

Merged
merged 1 commit into from
May 10, 2023
Merged

Fix definition of c_bool for non-MSVC targets. #54

merged 1 commit into from
May 10, 2023

Conversation

Arnavion
Copy link

Fixes #53

@Arnavion
Fix definition of c_bool for non-MSVC targets.
0b9954a 
Fixes #53

Signed-off-by: Arnav Singh <me@arnavion.dev>
@Arnavion
Copy link
Author

I tested this with the original code that I had the issue with and confirmed it works.

@Arnavion Arnavion mentioned this pull request May 10, 2023
Closed
@BusyJay BusyJay merged commit 0fef730 into tikv:main May 10, 2023
7 of 8 checks passed
@BusyJay
Copy link
Member

BusyJay commented May 10, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c_bool is not (always?) c_int, causes miscompilation of extent hook API
2 participants
@Arnavion @BusyJay