Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update jemalloc version #87

Closed
wants to merge 1 commit into from
Closed

Conversation

Rjected
Copy link

@Rjected Rjected commented May 13, 2024

It would be great to bump the jemalloc version since newer versions support profiling on macOS!

required for macos profiling

Signed-off-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@BusyJay
Copy link
Member

BusyJay commented May 14, 2024

Let's wait till it's officially released.

@Rjected
Copy link
Author

Rjected commented May 14, 2024

Let's wait till it's officially released.

unfortunately I'm not sure if that will happen any time soon: jemalloc/jemalloc#2604

In the case that jemalloc does not release in the next ~year, would there be an acceptable policy to adopt for bumping jemalloc versions, specifically validating that the bumped version is "good", w.r.t stability, testing, and benchmarking?

Maybe we could wait for the production tested commits?

Although even that seems to be updating at a slow pace

@BusyJay
Copy link
Member

BusyJay commented May 15, 2024

As this project is used widely in Rust ecosystem (directly or indirectly), I prefer to take a more conservative move. I'm aware of and have been watching the issue, but as the issue says, the listed commits are only verified on limited platforms and potentially break between commits.

@BusyJay
Copy link
Member

BusyJay commented May 15, 2024

Adding an issue to allow users to switch to dev code if they want: #88

@Rjected
Copy link
Author

Rjected commented May 15, 2024

As this project is used widely in Rust ecosystem (directly or indirectly), I prefer to take a more conservative move. I'm aware of and have been watching the issue, but as the issue says, the listed commits are only verified on limited platforms and potentially break between commits.

that makes sense, the issue looks like it would solve this use case so I'll close the PR

@Rjected Rjected closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants