wait time as a span #19
Conversation
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
| @@ -46,6 +88,6 @@ impl Drop for Collector { | |||
| fn drop(&mut self) { | |||
| self.inner | |||
| .closed | |||
| .store(true, std::sync::atomic::Ordering::SeqCst); | |||
| .store(true, std::sync::atomic::Ordering::Relaxed); | |||
There was a problem hiding this comment.
Any explanation about why Relaxed is enough now?
There was a problem hiding this comment.
Ordering is about two or more shared variables among multiple threads. If we don't have that synchronization semantics, relaxed is enough.
| @@ -42,14 +42,12 @@ static GLOBAL_ID_COUNTER: std::sync::atomic::AtomicU32 = std::sync::atomic::Atom | |||
|
|
|||
| #[inline] | |||
| fn next_global_id_prefix() -> u32 { | |||
| GLOBAL_ID_COUNTER.fetch_add(1, std::sync::atomic::Ordering::SeqCst) | |||
| GLOBAL_ID_COUNTER.fetch_add(1, std::sync::atomic::Ordering::Relaxed) | |||
| // fill the elapsed cycles of the first span | ||
| tl.spans[self.span_start_index].elapsed_cycles = | ||
| minstant::now().saturating_sub(tl.spans[self.span_start_index].begin_cycles); | ||
| // fill the elapsed cycles of the first span (except the leading span) |
There was a problem hiding this comment.
Any explanation about why created a new concept LeadingSpan and change logic here?
There was a problem hiding this comment.
A leading span is one of Root, Spawning, and Scheduling, which represents how a tracing context creates.
The elapsed time of a leading span means how long it waits from creating the task to starting execution.
A Settle span means the execution is starting.
There was a problem hiding this comment.
A leading span is one of
Root,Spawning, andScheduling, which represents how a tracing context creates.The elapsed time of a leading span means how long it waits from creating the task to starting execution.
A
Settlespan means the execution is starting.
Maybe this response can add to the comments in L142
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Signed-off-by: zhongzc zhongzc_arch@outlook.com
Changes:
span_setsinTraceDetails:Statebetween spans:State::Root,State::Settle,State::Local,State::Spawning,State::Scheduling.Root,SpawningandSchedulingare spans which indicate waiting for execution.