Skip to content

Commit

Permalink
api/member, server/join: use client.Ctx() (#358)
Browse files Browse the repository at this point in the history
  • Loading branch information
overvenus authored and siddontang committed Oct 23, 2016
1 parent c0af22f commit 3226d77
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions server/api/member.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ func newMemberListHandler(svr *server.Server, rd *render.Render) *memberListHand
}

func (h *memberListHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
ctx, cancel := context.WithTimeout(context.Background(), defaultDialTimeout)
defer cancel()
client := h.svr.GetClient()
ctx, cancel := context.WithTimeout(client.Ctx(), defaultDialTimeout)
defer cancel()

listResp, err := client.MemberList(ctx)
if err != nil {
Expand Down Expand Up @@ -88,7 +88,7 @@ func (h *memberDeleteHandler) ServeHTTP(w http.ResponseWriter, r *http.Request)
// step 1. get etcd id
var id uint64
name := (mux.Vars(r))["name"]
ctx, cancel := context.WithTimeout(context.Background(), defaultDialTimeout)
ctx, cancel := context.WithTimeout(client.Ctx(), defaultDialTimeout)
defer cancel()
listResp, err := client.MemberList(ctx)
if err != nil {
Expand All @@ -107,7 +107,7 @@ func (h *memberDeleteHandler) ServeHTTP(w http.ResponseWriter, r *http.Request)
}

// step 2. remove member by id
ctx, cancel = context.WithTimeout(context.Background(), defaultDialTimeout)
ctx, cancel = context.WithTimeout(client.Ctx(), defaultDialTimeout)
defer cancel()
_, err = client.MemberRemove(ctx, id)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions server/join.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ func genClientV3Config(cfg *Config) clientv3.Config {
}

func memberAdd(client *clientv3.Client, urls []string) (*clientv3.MemberAddResponse, error) {
ctx, cancel := context.WithTimeout(context.Background(), defaultDialTimeout)
ctx, cancel := context.WithTimeout(client.Ctx(), defaultDialTimeout)
defer cancel()

return client.MemberAdd(ctx, urls)
}

func memberList(client *clientv3.Client) (*clientv3.MemberListResponse, error) {
ctx, cancel := context.WithTimeout(context.Background(), defaultDialTimeout)
ctx, cancel := context.WithTimeout(client.Ctx(), defaultDialTimeout)
defer cancel()

return client.MemberList(ctx)
Expand Down

0 comments on commit 3226d77

Please sign in to comment.