Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics in resource group controller. #6136

Closed
CabinfeverB opened this issue Mar 10, 2023 · 0 comments · Fixed by #6170
Closed

Add metrics in resource group controller. #6136

CabinfeverB opened this issue Mar 10, 2023 · 0 comments · Fixed by #6170
Labels
type/development The issue belongs to a development tasks

Comments

@CabinfeverB
Copy link
Member

Development Task

Ref #5851, we have introduce the resource group controller. But currently, we only have debug level log for many important running information. So we need more metrics to show a lot of important performance metrics. Such as:

  • How many active resource groups are in controlled by this controller client.
  • token requests: 1. total token requests; 2.failed token requests
  • RU consumption
  • KV requests: 1. Total KV request; 2. Number of KV requests that have had a wait time and average waiting time.
@CabinfeverB CabinfeverB added the type/development The issue belongs to a development tasks label Mar 10, 2023
@CabinfeverB CabinfeverB mentioned this issue Mar 15, 2023
Merged
ti-chi-bot added a commit that referenced this issue Mar 20, 2023
@CabinfeverB @ti-chi-bot
resource_manager/client: introduce RU and Request metrics (#6170)
220dbed 
close #6136

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 21, 2023
Merged
ti-chi-bot added a commit to ti-chi-bot/pd that referenced this issue Mar 21, 2023
@CabinfeverB @ti-chi-bot
resource_manager/client: introduce RU and Request metrics (tikv#6170)
803e5d5 
close tikv#6136

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CabinfeverB added a commit to CabinfeverB/pd that referenced this issue Mar 22, 2023
@CabinfeverB @ti-chi-bot
resource_manager/client: introduce RU and Request metrics (tikv#6170)
0eb5850 
close tikv#6136

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
ti-chi-bot added a commit that referenced this issue Mar 22, 2023
@ti-chi-bot @CabinfeverB @lhy1024
resource_manager/client: introduce RU and Request metrics (#6170) (#6197
64761de 
)

close #6136, ref #6170

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: lhy1024 <admin@liudos.us>
CabinfeverB added a commit to ti-chi-bot/pd that referenced this issue Mar 22, 2023
@ti-chi-bot @CabinfeverB @lhy1024
resource_manager/client: introduce RU and Request metrics (tikv#6170) (…
118faa9 
…tikv#6197)

close tikv#6136, ref tikv#6170

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: lhy1024 <admin@liudos.us>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
CabinfeverB added a commit to ti-chi-bot/pd that referenced this issue Mar 22, 2023
@ti-chi-bot @CabinfeverB @lhy1024
resource_manager/client: introduce RU and Request metrics (tikv#6170) (…
d9d0378 
…tikv#6197)

close tikv#6136, ref tikv#6170

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: lhy1024 <admin@liudos.us>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/development The issue belongs to a development tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource_manager/client: introduce RU and Request metrics CabinfeverB/pd
1 participant
@CabinfeverB