Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client keeps updating the keyspace group discovery info #6508

Closed
rleungx opened this issue May 24, 2023 · 0 comments · Fixed by #6511
Closed

Client keeps updating the keyspace group discovery info #6508

rleungx opened this issue May 24, 2023 · 0 comments · Fixed by #6511
Assignees
Labels
severity/moderate The issue's severity is moderate. type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented May 24, 2023

Bug Report

What did you do?

img_v2_44c8f357-6335-4a46-92af-b94354ea762g

What did you expect to see?

There should be a few logs about updating the info of the discovery.

What did you see instead?

Too frequently and the members field keeps changing.

What version of PD are you using (pd-server -V)?

master

@rleungx rleungx added the type/bug The issue is confirmed as a bug. label May 24, 2023
@github-actions github-actions bot added this to Need Triage in Questions and Bug Reports May 24, 2023
@rleungx rleungx added the severity/moderate The issue's severity is moderate. label May 25, 2023
ti-chi-bot bot added a commit that referenced this issue May 25, 2023
…primary is changed (#6511)

close #6508

Skip logging of the tso service discovery info when the secondar list is changed,
because tso servers currently don't have consistent view of the member list due to
remote etcd being used by tso service, which results in changing member list when
the client queries the tso servers in round-robin. We need to improve the server side
so that all tso servers can return the global consistent view of the keyspace groups'
serving or membership info.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Questions and Bug Reports automation moved this from Need Triage to Closed May 25, 2023
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
…primary is changed (tikv#6511)

close tikv#6508

Skip logging of the tso service discovery info when the secondar list is changed,
because tso servers currently don't have consistent view of the member list due to
remote etcd being used by tso service, which results in changing member list when
the client queries the tso servers in round-robin. We need to improve the server side
so that all tso servers can return the global consistent view of the keyspace groups'
serving or membership info.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate The issue's severity is moderate. type/bug The issue is confirmed as a bug.
Projects
2 participants