Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestHandleTSORequestWithWrongMembership has random failure #6532

Closed
binshi-bing opened this issue May 29, 2023 · 0 comments · Fixed by #6533
Closed

TestHandleTSORequestWithWrongMembership has random failure #6532

binshi-bing opened this issue May 29, 2023 · 0 comments · Fixed by #6533
Assignees
@binshi-bing
Labels
type/ci The issue is related to CI.

Comments

@binshi-bing
Copy link
Contributor

Flaky Test

Which jobs are failing

TestHandleTSORequestWithWrongMembership

CI link

https://github.com/tikv/pd/actions/runs/5108560521/jobs/9182485738?pr=6526

Reason for failure (if possible)

the primary election mightn't complete yet, so the tso service mightn't be avilable.

Anything else
@binshi-bing binshi-bing added the type/ci The issue is related to CI. label May 29, 2023
@binshi-bing binshi-bing self-assigned this May 29, 2023
@binshi-bing binshi-bing mentioned this issue May 29, 2023
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in a432973 May 29, 2023
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@binshi-bing @rleungx
tso: fix flaky test TestHandleTSORequestWithWrongMembership (tikv#6533)
e23ac5e 
close tikv#6532

Add loop to wait for primary election to complete so that the tso service availability is deterministic.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binshi-bing binshi-bing

Labels
type/ci The issue is related to CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tso: fix flaky test TestHandleTSORequestWithWrongMembership binshi-bing/pd
1 participant
@binshi-bing