Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyspace: fail to split keyspace group twice #6611

Closed
lhy1024 opened this issue Jun 15, 2023 · 1 comment · Fixed by #6612
Closed

keyspace: fail to split keyspace group twice #6611

lhy1024 opened this issue Jun 15, 2023 · 1 comment · Fixed by #6612
Labels
severity/major The issue's severity is major. type/bug The issue is confirmed as a bug.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Jun 15, 2023

Bug Report

What did you do?

run a cluster with pre-alloc "keyspace_a" and "keyspace_b"
15e6fac3-650b-4c4c-8e83-fdbb58e032b7

run ./pd-ctl keyspace-group 0 1 2
3f6a2079-ab26-490e-b146-4fdc73ddd45a

but it keep in split and fail to split again

aa36834e-2a85-4f44-a120-37893f5bd9b6

What did you expect to see?

split twice successful

What did you see instead?

failed

What version of PD are you using (pd-server -V)?

master

@lhy1024 lhy1024 added the type/bug The issue is confirmed as a bug. label Jun 15, 2023
@github-actions github-actions bot added this to Need Triage in Questions and Bug Reports Jun 15, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 15, 2023

It is a bug in pd client.

We create tsoSvcDiscovery with setServiceMode in

c.pdSvcDiscovery = newPDServiceDiscovery(

And we get keyspace id with loadKeyspaceMeta in

if err := c.initRetry(c.loadKeyspaceMeta, keyspaceName); err != nil {

We only update keyspaceID in pdSvcDiscovery and tsoSvcDiscovery still use default keyspace.

@lhy1024 lhy1024 added the severity/major The issue's severity is major. label Jun 15, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jun 16, 2023
close #6611

Signed-off-by: lhy1024 <admin@liudos.us>
Questions and Bug Reports automation moved this from Need Triage to Closed Jun 16, 2023
lhy1024 added a commit to lhy1024/pd that referenced this issue Jun 16, 2023
close tikv#6611

Signed-off-by: lhy1024 <admin@liudos.us>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
close tikv#6611

Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/major The issue's severity is major. type/bug The issue is confirmed as a bug.
Projects
Development

Successfully merging a pull request may close this issue.

1 participant