Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdctl/TestScheduler is unstable #7062

Closed
HuSharp opened this issue Sep 8, 2023 · 3 comments · Fixed by #7074 or #8093
Closed

pdctl/TestScheduler is unstable #7062

HuSharp opened this issue Sep 8, 2023 · 3 comments · Fixed by #7074 or #8093
Labels
type/ci The issue is related to CI.

Comments

@HuSharp
Copy link
Member

HuSharp commented Sep 8, 2023

Flaky Test

Which jobs are failing

--- FAIL: TestScheduler (6.24s)
    scheduler_test.go:121: 
        	Error Trace:	/home/runner/work/pd/pd/tests/pdctl/scheduler/scheduler_test.go:121
        	            				/home/runner/work/pd/pd/tests/pdctl/scheduler/scheduler_test.go:146
        	Error:      	Not equal: 
        	            	expected: "1 store(s) RegionNotMatchRule; "
        	            	actual  : "1 store(s) StoreScoreDisallowed; 1 store(s) RegionNotMatchRule; "
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-1 store(s) RegionNotMatchRule; 
        	            	+1 store(s) StoreScoreDisallowed; 1 store(s) RegionNotMatchRule; 
        	Test:       	TestScheduler

CI link

https://github.com/tikv/pd/actions/runs/6120378650/job/16612129573?pr=7054
https://github.com/tikv/pd/actions/runs/6117443392/job/16604072119

Reason for failure (if possible)

Anything else
@HuSharp HuSharp added the type/ci The issue is related to CI. label Sep 8, 2023
This was referenced Sep 11, 2023
Merged
Closed
CabinfeverB added a commit to CabinfeverB/pd that referenced this issue Sep 11, 2023
@CabinfeverB
fix tikv#7062
0fa3999 
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB CabinfeverB mentioned this issue Sep 11, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Sep 11, 2023
@CabinfeverB @ti-chi-bot
test: fix unstable test TestScheduler (#7074)
68df4b6 
close #7062

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this issue Sep 11, 2023
@rleungx
*: split the TestScheduler (#7064)
58113f8 
ref #7062

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 19, 2023 

--- FAIL: TestScheduler (4.95s)
    scheduler_test.go:84: 
        	Error Trace:	/home/runner/work/pd/pd/tests/pdctl/scheduler/scheduler_test.go:84
        	            				/home/runner/work/pd/pd/tests/pdctl/scheduler/scheduler_test.go:139
        	Error:      	Should be true
        	Test:       	TestScheduler

https://github.com/tikv/pd/actions/runs/6231651596/job/16913501641?pr=7089

@lhy1024 lhy1024 reopened this Sep 19, 2023
@rleungx
Copy link
Member

rleungx commented Feb 29, 2024 

    scheduler_test.go:521: 
        	Error Trace:	/home/runner/work/pd/pd/tools/pd-ctl/tests/scheduler/scheduler_test.go:521
        	            				/home/runner/work/pd/pd/tests/testutil.go:310
        	            				/home/runner/work/pd/pd/tests/testutil.go:271
        	            				/home/runner/work/pd/pd/tools/pd-ctl/tests/scheduler/scheduler_test.go:102
        	Error:      	"{\n  \"ranges\": [\n    {\n      \"start-key\": \"\",\n      \"end-key\": \"\"\n    }\n  ],\n  \"batch\": 3\n}\n\n" does not contain "404"
        	Test:       	TestSchedulerTestSuite/TestScheduler

https://github.com/tikv/pd/actions/runs/8092030989/job/22112045987?pr=7823

@rleungx
Copy link
Member

rleungx commented Apr 18, 2024

https://github.com/tikv/pd/actions/runs/8734060923/job/23963960119?pr=8092

@rleungx rleungx mentioned this issue Apr 18, 2024
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #8093 May 7, 2024
ti-chi-bot bot added a commit that referenced this issue May 7, 2024
@rleungx @ti-chi-bot
*: make TestScheduler stable (#8093)
b41c897 
close #7062

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/ci The issue is related to CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix unstable test TestScheduler CabinfeverB/pd
*: make TestScheduler stable rleungx/pd
3 participants
@lhy1024 @rleungx @HuSharp