Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: disable plugin in default and persist file in specified dir #7094

Closed
HuSharp opened this issue Sep 14, 2023 · 1 comment · Fixed by #7087
Closed

security: disable plugin in default and persist file in specified dir #7094

HuSharp opened this issue Sep 14, 2023 · 1 comment · Fixed by #7087
Labels
affects-6.5 affects-7.1 severity/minor The issue's severity is minor. type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports

Comments

@HuSharp
Copy link
Member

HuSharp commented Sep 14, 2023

Bug Report

There are some leaks to inject errors.

  • load mistake plugin anywhere
  • no need to expose the persist interface, we just use it in DR_STATS

What did you do?

What did you expect to see?

  • Load plugin and persist file in specified dir [config data dir]
  • Judge persist file name rather than delete this interface to keep compatible
  • support a config to decide whether to enable the plugin

What did you see instead?

some leaks

What version of PD are you using (pd-server -V)?

master
@HuSharp HuSharp added the type/bug The issue is confirmed as a bug. label Sep 14, 2023
@github-actions github-actions bot added this to Need Triage in Questions and Bug Reports Sep 14, 2023
@HuSharp HuSharp mentioned this issue Sep 14, 2023
Merged
@jebter
Copy link
Collaborator

jebter commented Sep 21, 2023

/severit major

@HuSharp HuSharp added severity/minor The issue's severity is minor. affects-6.5 affects-7.1 labels Sep 21, 2023
Questions and Bug Reports automation moved this from Need Triage to Closed Sep 22, 2023
ti-chi-bot bot added a commit that referenced this issue Sep 22, 2023
@HuSharp @ti-chi-bot
security: disable plugin in default and persist file in specified dir (…
a21fd58 
…#7087)

close #7094

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Sep 22, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#7087
a1410ed 
close tikv#7094

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Sep 22, 2023
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Sep 22, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#7087
b130fdf 
close tikv#7094

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this issue Sep 25, 2023
@ti-chi-bot @HuSharp
security: disable plugin in default and persist file in specified dir (…
5b491e2 
…#7087) (#7141)

close #7094

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
Co-authored-by: Hu# <jinhao.hu@pingcap.com>
ti-chi-bot bot added a commit that referenced this issue Sep 28, 2023
@ti-chi-bot @HuSharp @ti-chi-bot
security: disable plugin in default and persist file in specified dir (…
905d8ff 
…#7087) (#7142)

close #7094

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
Co-authored-by: Hu# <jinhao.hu@pingcap.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@niubell niubell mentioned this issue Oct 18, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 severity/minor The issue's severity is minor. type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

security: disable plugin in default and persist file in specified dir HuSharp/pd
2 participants
@jebter @HuSharp