Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replication mode: available_stores is wrongly calculated #7221

Closed
disksing opened this issue Oct 18, 2023 · 0 comments · Fixed by #7222
Closed

replication mode: available_stores is wrongly calculated #7221

disksing opened this issue Oct 18, 2023 · 0 comments · Fixed by #7222
Assignees
@disksing
Labels
affects-6.5 affects-7.1 affects-7.5 severity/major The issue's severity is major. type/bug The issue is confirmed as a bug.
Projects
Synchronous replication in dual data ... Questions and Bug Reports

Comments

@disksing
Copy link
Contributor

Bug Report

What did you do?

when some stores are configured to be used to schedule learners, they should be contained in available stores list.

What did you expect to see?

available stores list contains stores that only have raft learners.

What did you see instead?

available stores list does not contain stores that only have raft learners.

What version of PD are you using (pd-server -V)?

master/v6.5.5
@disksing disksing added type/bug The issue is confirmed as a bug. affects-6.5 labels Oct 18, 2023
@disksing disksing self-assigned this Oct 18, 2023
@github-actions github-actions bot added this to Need Triage in Questions and Bug Reports Oct 18, 2023
disksing added a commit to oh-my-tidb/pd that referenced this issue Oct 18, 2023
@disksing
fix tikv#7221
25fa6cf 
replication mode: fix wrong available store list

Signed-off-by: disksing <i@disksing.com>
disksing added a commit to oh-my-tidb/pd that referenced this issue Oct 18, 2023
@disksing
replication mode: fix wrong available store list
7f4140c 
fix tikv#7221

Signed-off-by: disksing <i@disksing.com>
@disksing disksing mentioned this issue Oct 18, 2023
Merged
@disksing disksing added the severity/major The issue's severity is major. label Oct 18, 2023
Synchronous replication in dual data centers automation moved this from To do to Done Oct 18, 2023
Questions and Bug Reports automation moved this from Need Triage to Closed Oct 18, 2023
ti-chi-bot bot pushed a commit that referenced this issue Oct 18, 2023
@disksing
replication mode: fix wrong available store list (#7222)
cb9c70c 
close #7221

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot mentioned this issue Oct 18, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Oct 18, 2023
@disksing @ti-chi-bot
replication mode: fix wrong available store list
6e5b6b5 
fix tikv#7221

Signed-off-by: disksing <i@disksing.com>
ti-chi-bot bot pushed a commit that referenced this issue Oct 18, 2023
@ti-chi-bot @disksing
replication mode: fix wrong available store list (#7222) (#7224)
e0ab17c 
close #7221

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
disksing added a commit to oh-my-tidb/pd that referenced this issue Oct 30, 2023
@ti-chi-bot @disksing
replication mode: fix wrong available store list (tikv#7222) (tikv#7224)
0f471b9 
close tikv#7221

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 8, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 8, 2023
@disksing @ti-chi-bot
replication mode: fix wrong available store list
3d512eb 
fix tikv#7221

Signed-off-by: disksing <i@disksing.com>
ti-chi-bot bot pushed a commit that referenced this issue Nov 8, 2023
@ti-chi-bot @disksing
replication mode: fix wrong available store list (#7222) (#7328)
710ffcd 
close #7221

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
@niubell niubell mentioned this issue Nov 15, 2023
Merged
18 tasks
@niubell niubell mentioned this issue Nov 30, 2023
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Feb 1, 2024
@disksing @ti-chi-bot
This is an automated cherry-pick of tikv#7222
9f67bab 
close tikv#7221

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 1, 2024
Closed
disksing added a commit to oh-my-tidb/pd that referenced this issue Feb 1, 2024
@ti-chi-bot @disksing
replication mode: fix wrong available store list (tikv#7222) (tikv#7224)
d8cee91 
close tikv#7221

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
@disksing disksing mentioned this issue Feb 18, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Feb 18, 2024
@disksing @ti-chi-bot
replication: cherry-pick improvements for dr-autosync (#7789)
e00f31e 
close #7221

improve state replication and failover process for dr-autosync

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disksing disksing

Labels
affects-6.5 affects-7.1 affects-7.5 severity/major The issue's severity is major. type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
  
Closed
Synchronous replication in dual data ...
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replication mode: fix wrong available store list oh-my-tidb/pd
2 participants
@disksing @ti-chi-bot