pdctl: support filter json output by calling external jq #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connor1996
reviewed
Jul 2, 2018
siddontang
reviewed
Jul 3, 2018
| @@ -42,7 +43,7 @@ type regionInfo struct { | |||
| // NewRegionCommand return a region subcommand of rootCmd | |||
| func NewRegionCommand() *cobra.Command { | |||
| r := &cobra.Command{ | |||
| Use: "region <region_id>", | |||
| Use: `region <region_id> [-jq="<query string>"]`, | |||
There was a problem hiding this comment.
only support some commands?
There was a problem hiding this comment.
Yes. Only support APIs that query region/store list. The results returned by other APIs are simple and easy to see with the naked eye.
siddontang
reviewed
Jul 3, 2018
| @@ -82,6 +84,11 @@ func showRegionCommandFunc(cmd *cobra.Command, args []string) { | |||
| fmt.Printf("Failed to get region: %s\n", err) | |||
| return | |||
| } | |||
| if flag := cmd.Flag("jq"); flag != nil && flag.Value.String() != "" { | |||
There was a problem hiding this comment.
can we provide a Print interface for jq or standard output?
There was a problem hiding this comment.
It's possible but I don't think it's necessary.
There was a problem hiding this comment.
seem better to extract to a function like isJQUsed
There was a problem hiding this comment.
There is no need to over-abstract, --jq is not a general parameter. these two commands just happen to both support it.
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Aug 15, 2018
* pdctl: support filter json output by calling external jq * update vendor * support jq for store command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (required)
shellwordsto split command line stringsjqbe installed in the system. We may want to include ajqbinary in our release package.What are the type of the changes (required)?
How has this PR been tested (required)?
Does this PR affect documentation (docs/docs-cn) update? (optional)
Yes. See pingcap/docs-cn#790