pd-ctl: add policy selection for split region #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to supply to split key to split region too? |
|
@disksing No, there is a command for tikv-ctl to split region on specified split key. And this split region command for pd is just half split. |
|
LGTM |
disksing
approved these changes
Jul 17, 2018
|
Please switch to master kvproto before merge. |
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Aug 15, 2018
* add policy for split region * update kvproto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (required)
Currently TiKV support get approximate middle key from properties, so when split region add a check-policy field to specify to use which way.
What are the type of the changes (required)?
Improvement (non-breaking change which is an improvement to an existing feature)
How has this PR been tested (required)?
manual test
Does this PR affect documentation (docs/docs-cn) update? (optional)
pingcap/docs-cn#809
Refer to a related PR or issue link (optional)
pingcap/kvproto#287