server/coordinator: startup schedulers with considering the proportion of regions #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of regions activated on each store
rleungx
reviewed
Aug 30, 2018
server/core/region.go
Outdated
| @@ -486,10 +486,6 @@ func (r *RegionsInfo) AddRegion(region *RegionInfo) []*metapb.Region { | |||
|
|
|||
| r.regions.Put(region) | |||
|
|
|||
| if region.Leader == nil { | |||
There was a problem hiding this comment.
It seems that it cannot be removed because it might be use in region.Leader.GetId().
disksing
approved these changes
Sep 3, 2018
|
em, have you run a cluster to manually test it? |
|
I do 2 cases with the manual test. One is simulator 200 stores and Isolate the network of PD and a TiKV, then restart the PD and the coordinator will not start until timeout. Another with 4 stores and isolate a store then restart the PD, the coordinator will start because the heartbeat can be completely collected by the new leaders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n of regions activated on each store
What problem does this PR solve?
If we have many stores, like 10 stores, and restart the cluster. 9 stores already reported a heartbeat and the last not finished. the schedulers will begin to schedule and do some unnecessary balance.
What is changed and how it works?
This PR startup schedulers with considering the proportion of regions activated on each store.
Check List
Tests