Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: add light peer without considering the influence #1554

Merged
merged 2 commits into from Jun 4, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 30, 2019

What problem does this PR solve?

After #1474, we introduce a limit mechanism for each store by considering the influence of add peer operation. But there is a special operation, region scatter, which shouldn't be limited.

What is changed and how it works?

This PR introduces two more steps named AddLightLearner and AddLightPeer respectively to solve this problem.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release notes

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added component/schedule Scheduling logic. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. labels May 30, 2019
@rleungx rleungx requested review from nolouch and disksing May 30, 2019 03:39
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

server/schedule/operator_controller.go Show resolved Hide resolved
server/schedule/operator_controller.go Show resolved Hide resolved
@shafreeck shafreeck self-requested a review June 3, 2019 11:44
@nolouch nolouch merged commit 039573c into tikv:master Jun 4, 2019
rleungx added a commit to rleungx/pd that referenced this pull request Jun 4, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch pushed a commit that referenced this pull request Jun 5, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants