Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix the issue that some scheduler persist config without solving error #2817

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Aug 21, 2020

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

fix the issue that some scheduler persist config without solving error

What is changed and how it works?

return with error

Check List

Tests

  • Unit test

Release note

@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 21, 2020

Need it to cherry-pick to 4.0?

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 21, 2020
@lhy1024 lhy1024 added the needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. label Aug 21, 2020
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 21, 2020
@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 21, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 21, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 21, 2020

/merge

@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 21, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit b35148e into tikv:master Aug 21, 2020
ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Aug 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2818

ZenoTan pushed a commit to ZenoTan/pd that referenced this pull request Aug 24, 2020
…olving error (tikv#2817)

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: ZenoTan <zenotan1998@gmail.com>
jyz0309 pushed a commit to jyz0309/pd that referenced this pull request Aug 24, 2020
…olving error (tikv#2817)

Signed-off-by: lhy1024 <admin@liudos.us>
jyz0309 pushed a commit to jyz0309/pd that referenced this pull request Aug 24, 2020
…olving error (tikv#2817)

Signed-off-by: lhy1024 <admin@liudos.us>
ti-srebot added a commit that referenced this pull request Sep 1, 2020
…olving error (#2817) (#2818)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants