*: optimize log and make their specification consistent #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
commented
Aug 27, 2020
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/rebuild |
rleungx
force-pushed
the
optimize-log
branch
2 times, most recently
from
18b362f
to
1712dda
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
optimize-log
branch
from
a315a9d
to
a4b45e7
Compare
lhy1024
reviewed
Sep 1, 2020
| continue | ||
| } | ||
|
|
||
| b, err := ioutil.ReadAll(resp.Body) | ||
| resp.Body.Close() | ||
| if err != nil { | ||
| log.Error("read failed", errs.ZapError(errs.ErrReadHTTPBody, err)) | ||
| log.Error("read failed", errs.ZapError(errs.ErrIORead, err)) |
| // tso errors | ||
| var ( | ||
| ErrInvalidTimestamp = errors.Normalize("invalid timestamp", errors.RFCCodeText("PD:tso:ErrInvalidTimestamp")) | ||
| ErrLogicOverflow = errors.Normalize("logic part overflow", errors.RFCCodeText("PD:tso:ErrLogicOverflow")) | ||
| ErrIncorrectSystemTime = errors.Normalize("incorrect system time", errors.RFCCodeText("PD:tso:ErrIncorrectSystemTime")) | ||
| ) | ||
|
|
||
| // adapter errors | ||
| // member errors |
There was a problem hiding this comment.
On what basis do we rank these errors?
There was a problem hiding this comment.
IMO, we just need to distinguish the errors generated in PD internal or in the third-party package. There is no rank concept.
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
optimize-log
branch
from
a4b45e7
to
6e08a84
Compare
server/election/leadership.go
Outdated
| @@ -34,7 +34,7 @@ func GetLeader(c *clientv3.Client, leaderPath string) (*pdpb.Member, int64, erro | |||
| leader := &pdpb.Member{} | |||
| ok, rev, err := etcdutil.GetProtoMsgWithModRev(c, leaderPath, leader) | |||
| if err != nil { | |||
| return nil, 0, err | |||
| return nil, 0, errs.ErrEtcdGetProtoMsgWithModRev.Wrap(err).FastGenWithCause() | |||
There was a problem hiding this comment.
i think we should handle errors in the lower level
| } | ||
| if !resp.Succeeded { | ||
| return errors.WithStack(errTxnFailed) | ||
| return errs.ErrEtcdTxn.FastGenByArgs() |
There was a problem hiding this comment.
This error has a %s placeholder. is it ok to pass no argument?
Signed-off-by: Ryan Leung <rleungx@gmail.com>
lhy1024
reviewed
Sep 1, 2020
server/member/member.go
Outdated
Comment on lines
160
to
161
| err := errs.ErrEtcdLeaderNotFound.FastGenByArgs() | ||
| log.Error("no etcd leader, check pd leader later", errs.ZapError(err)) |
There was a problem hiding this comment.
Suggested change
| err := errs.ErrEtcdLeaderNotFound.FastGenByArgs() | |
| log.Error("no etcd leader, check pd leader later", errs.ZapError(err)) | |
| log.Error("no etcd leader, check pd leader later", errs.ZapError(errs.ErrEtcdLeaderNotFound)) |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
howardlau1999
approved these changes
Sep 1, 2020
|
@howardlau1999,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
|
@lhy1024 PTAL |
|
/run-all-tests |
lhy1024
approved these changes
Sep 1, 2020
ti-srebot
approved these changes
Sep 1, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
howardlau1999
pushed a commit
to howardlau1999/pd
that referenced
this pull request
Sep 2, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: Howard Lau <howardlau1999@hotmail.com>
rleungx
added
the
needs-cherry-pick-release-4.0
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Sep 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #2903 |
rleungx
added a commit
to ti-srebot/pd
that referenced
this pull request
Sep 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
rleungx
added a commit
to ti-srebot/pd
that referenced
this pull request
Sep 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
rleungx
added a commit
to ti-srebot/pd
that referenced
this pull request
Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
added a commit
to ti-srebot/pd
that referenced
this pull request
Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
added a commit
to ti-srebot/pd
that referenced
this pull request
Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
added a commit
to ti-srebot/pd
that referenced
this pull request
Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-srebot
added a commit
that referenced
this pull request
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related to #2704.
What is changed and how it works?
This PR does some optimization for the error log by defining the error when we first meet it.
Check List
Tests
Related changes
Release note