Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the log errs in scheduler (#2705) #2900

Merged
merged 7 commits into from
Sep 4, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2705 to release-4.0


Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

To solve #2704

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 4, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 4, 2020

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 4, 2020

/run-integration-ddl-test

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #2900 into release-4.0 will decrease coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2900      +/-   ##
===============================================
- Coverage        77.41%   77.38%   -0.04%     
===============================================
  Files              210      210              
  Lines            22780    22784       +4     
===============================================
- Hits             17636    17631       -5     
- Misses            3813     3822       +9     
  Partials          1331     1331              
Impacted Files Coverage Δ
server/cluster/cluster_worker.go 72.95% <0.00%> (ø)
server/schedulers/balance_region.go 85.38% <0.00%> (ø)
server/schedulers/base_scheduler.go 69.56% <0.00%> (ø)
server/schedulers/hot_region.go 82.11% <0.00%> (ø)
server/schedulers/label.go 74.24% <0.00%> (ø)
server/schedulers/random_merge.go 64.17% <0.00%> (ø)
server/schedulers/scatter_range.go 83.01% <0.00%> (ø)
server/schedulers/shuffle_hot_region.go 74.78% <0.00%> (ø)
server/schedulers/shuffle_region.go 83.52% <0.00%> (ø)
server/schedulers/utils.go 92.17% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 463e0f1...05357f7. Read the comment docs.

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 4, 2020

/run-all-tests

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 4, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 4, 2020

@rleungx PTAL. Can we merge it?

@nolouch
Copy link
Contributor

nolouch commented Sep 4, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 4, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants