Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: refine error log in cluster pkg (#2868) #2906

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2868 to release-4.0


Signed-off-by: Howard Lau howardlau1999@hotmail.com

What problem does this PR solve?

To solve #2704

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick type/enhancement The issue belongs to an enhancement. labels Sep 7, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 7, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 7, 2020

/run-all-tests

@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/cc @howardlau1999

@ti-srebot
Copy link
Contributor Author

@howardlau1999,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: scheduling(slack).

@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 7, 2020
@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@howardlau1999
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2906 into release-4.0 will increase coverage by 0.46%.
The diff coverage is 13.63%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2906      +/-   ##
===============================================
+ Coverage        77.37%   77.84%   +0.46%     
===============================================
  Files              210      210              
  Lines            22793    22803      +10     
===============================================
+ Hits             17637    17750     +113     
+ Misses            3825     3721     -104     
- Partials          1331     1332       +1     
Impacted Files Coverage Δ
server/api/middleware.go 75.00% <0.00%> (ø)
server/handler.go 51.19% <0.00%> (+0.43%) ⬆️
server/kv/etcd_kv.go 82.27% <0.00%> (+8.86%) ⬆️
server/schedule/plugin_interface.go 20.00% <0.00%> (+0.95%) ⬆️
server/server.go 76.82% <0.00%> (-0.75%) ⬇️
server/cluster/coordinator.go 70.33% <8.00%> (+0.31%) ⬆️
server/cluster/cluster.go 83.75% <12.50%> (+2.84%) ⬆️
server/core/storage.go 72.86% <20.00%> (-0.57%) ⬇️
pkg/etcdutil/etcdutil.go 86.30% <33.33%> (-5.25%) ⬇️
server/schedule/scheduler.go 65.30% <44.44%> (-4.47%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8671fe...d9ffdf8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants