Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add missing error handling #2915

Merged
merged 3 commits into from
Sep 7, 2020
Merged

*: add missing error handling #2915

merged 3 commits into from
Sep 7, 2020

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Sep 7, 2020

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

cherry-pick #2708 #2878 to release-4.0

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added component/testing CI testing. component/log Log. component/placement Placement rule. component/tso Timestamp Oracle. labels Sep 7, 2020
@JmPotato JmPotato added this to the v4.0.6 milestone Sep 7, 2020
@JmPotato JmPotato self-assigned this Sep 7, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2020
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 7, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2915 into release-4.0 will decrease coverage by 0.44%.
The diff coverage is 77.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2915      +/-   ##
===============================================
- Coverage        77.82%   77.38%   -0.45%     
===============================================
  Files              210      210              
  Lines            22854    22854              
===============================================
- Hits             17786    17685     -101     
- Misses            3729     3830     +101     
  Partials          1339     1339              
Impacted Files Coverage Δ
server/tso/tso.go 78.48% <55.55%> (-3.80%) ⬇️
server/schedule/placement/rule_list.go 97.50% <100.00%> (ø)
server/schedule/placement/rule_manager.go 75.32% <100.00%> (ø)
server/statistics/store_collection.go 58.82% <0.00%> (-34.56%) ⬇️
server/region_syncer/server.go 80.55% <0.00%> (-9.73%) ⬇️
server/heartbeat_streams.go 68.00% <0.00%> (-6.00%) ⬇️
server/cluster/cluster.go 80.91% <0.00%> (-2.85%) ⬇️
server/config/persist_options.go 89.76% <0.00%> (-1.58%) ⬇️
server/server.go 76.18% <0.00%> (-1.19%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee47f6d...7242b80. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. component/placement Placement rule. component/testing CI testing. component/tso Timestamp Oracle. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants