Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: update google/btree #356

Merged
merged 2 commits into from
Oct 23, 2016
Merged

vendor: update google/btree #356

merged 2 commits into from
Oct 23, 2016

Conversation

huachaohuang
Copy link
Contributor

For cache optimization.

@ngaut
Copy link
Member

ngaut commented Oct 22, 2016

LGTM

siddontang
siddontang reviewed Oct 22, 2016
View reviewed changes
Makefile
rm -rf _vendor
ifdef PKG
glide get --strip-vendor --skip-test ${PKG}
glide update --strip-vendor --skip-test ${PKG}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the first adding, update can work?

@siddontang
Copy link
Contributor

Rest LGTM

@huachaohuang huachaohuang mentioned this pull request Oct 23, 2016
Merged
@huachaohuang
Copy link
Contributor Author

At least one approved review is required.
@overvenus @siddontang

@siddontang
Copy link
Contributor

LGTM

@siddontang siddontang merged commit dcfe726 into master Oct 23, 2016
@siddontang siddontang deleted the huachaohuang/update-vendor branch October 23, 2016 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huachaohuang @ngaut @siddontang