New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler (#4106) #4116
scheduler: allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler (#4106) #4116
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@lhy1024 plz fix the conflict. |
Signed-off-by: lhy1024 <admin@liudos.us>
78380b2
to
bde2b3a
Compare
CI failed |
Codecov Report
@@ Coverage Diff @@
## release-5.0 #4116 +/- ##
===============================================
- Coverage 75.05% 74.88% -0.17%
===============================================
Files 245 245
Lines 24370 24382 +12
===============================================
- Hits 18290 18258 -32
- Misses 4475 4506 +31
- Partials 1605 1618 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: a6cf0a2
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/rebuild |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #4106
What problem does this PR solve?
we expect the tolerance ratio in range cluster should be 2, but it doesn't take effect.
pd/server/schedulers/scatter_range.go
Line 220 in 3f53f1e
pd/server/schedulers/utils.go
Line 154 in 3f53f1e
we expect it can schedule empty region, but it can not and test can not detect
pd/server/core/region.go
Line 96 in 3f53f1e
pd/server/schedulers/balance_test.go
Lines 1103 to 1111 in 3f53f1e
What is changed and how it works?
allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler
Check List
Tests
Add scatter range scheduler
Before this pr
After this pr
Related changes
Release note