Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler (#4106) #4116

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4106

What problem does this PR solve?

  1. we expect the tolerance ratio in range cluster should be 2, but it doesn't take effect.

    c.SetTolerantSizeRatio(2)

    tolerantSizeRatio := cluster.GetOpts().GetTolerantSizeRatio()

  2. we expect it can schedule empty region, but it can not and test can not detect

    EmptyRegionApproximateSize = 1

    // empty case
    regions[49].EndKey = []byte("")
    for _, meta := range regions {
    leader := rand.Intn(4) % 3
    regionInfo := core.NewRegionInfo(
    meta,
    meta.Peers[leader],
    core.SetApproximateKeys(96),
    core.SetApproximateSize(96),

What is changed and how it works?

allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Add scatter range scheduler

Before this pr
image
After this pr
image

Related changes

  • Need to cherry-pick to the release branch

Release note

allow empty region to be scheduled and use a sperate tolerance config in scatter range scheduler

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note The PR should write the release note. do-not-merge/cherry-pick-not-approved component/scheduler Scheduler logic. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick. labels Sep 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 30, 2021

@lhy1024 plz fix the conflict.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 30, 2021
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@rleungx
Copy link
Member

rleungx commented Dec 1, 2021

CI failed

@lhy1024 lhy1024 self-requested a review December 1, 2021 18:30
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #4116 (f0b312d) into release-5.0 (7161fde) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #4116      +/-   ##
===============================================
- Coverage        75.05%   74.88%   -0.17%     
===============================================
  Files              245      245              
  Lines            24370    24382      +12     
===============================================
- Hits             18290    18258      -32     
- Misses            4475     4506      +31     
- Partials          1605     1618      +13     
Flag Coverage Δ
unittests 74.88% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/balance_region.go 87.40% <100.00%> (+0.62%) ⬆️
server/schedulers/utils.go 93.90% <100.00%> (+0.23%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/member/member.go 63.04% <0.00%> (-8.16%) ⬇️
server/tso/tso.go 68.71% <0.00%> (-6.75%) ⬇️
server/id/id.go 80.95% <0.00%> (-4.77%) ⬇️
server/tso/allocator_manager.go 75.74% <0.00%> (-3.66%) ⬇️
server/election/leadership.go 87.05% <0.00%> (-2.36%) ⬇️
client/base_client.go 82.47% <0.00%> (-2.07%) ⬇️
server/election/lease.go 94.91% <0.00%> (-1.70%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7161fde...f0b312d. Read the comment docs.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 6, 2021
@lhy1024
Copy link
Contributor

lhy1024 commented Dec 6, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a6cf0a2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 6, 2021

/rebuild

@nolouch
Copy link
Contributor

nolouch commented Dec 6, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 634194f into tikv:release-5.0 Dec 6, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.0.6 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. release-note The PR should write the release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. triage/accept type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants