server: clean up tombstone status #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overvenus
requested review from
siddontang and
huachaohuang
and removed request for
siddontang
huachaohuang
reviewed
Dec 9, 2016
| @@ -394,6 +394,11 @@ func (c *RaftCluster) BuryStore(storeID uint64, force bool) error { | |||
| } | |||
|
|
|||
| store.State = metapb.StoreState_Tombstone | |||
| store.stats.TotalRegionCount = 0 | |||
There was a problem hiding this comment.
You can just set it to an empty struct.
There was a problem hiding this comment.
Okay, though we may lose some infomation.
|
LGTM |
huachaohuang
approved these changes
Dec 10, 2016
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @huachaohuang @siddontang
Close #401