Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: Add APIs for RawKV GC #4937
storage: Add APIs for RawKV GC #4937
Changes from 5 commits
32c44ee
b12eb9b
d0b4f3b
a2ba0e7
b9bb3e4
a7e3ece
7ff125e
1bdb642
1ebb51d
312704a
766b344
de77dfc
d6eda93
cbe1ed0
9b27bcd
88610a0
995033e
3099939
a825d37
c1cb1c0
769a40b
d8dd130
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we know the endpoint types from
service_id
? such as it's fromtidb
,raw_kv client
,cdc
or others?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can tell by
service_id
alone,for example, both
TiDB
andraw_kv's gc_worker
may usegc_worker
as theirservice_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... Is it different in space_id? like
cdc_xxx
,tidb_xxx
,client_xxxx
. I would like to know who use the path.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently, we use
spaceID
to differentiate key spaces, things likedefault_rawkv
,default_txnkv
,default_tidb
serviceID
is used to identify the specific service under thatKeySpace
, likecdc
,br
, etc.tidb cdc
andrawkv cdc
may have the sameserviceID
but differentspaceID
srawkv cdc
andrawkv br
have the samespaceID
but differentserviceID
s